undead, on 07 August 2012 - 11:15 PM, said:
It has a lot more changes than needed when I go through the list. If you set LEGACY_PROTOCOL and STANDALONE, you don't need to remove a lot of code that the official UrT client does. Upstream ioquake3 made it much cleaner to have a standalone game. The official UrT client is too old to have those changes.
Yep. Been using the LEGACY_PROTOCOL :)
undead, on 07 August 2012 - 11:15 PM, said:
Could you have the plain 4.2 changes enabled by default and #ifdef protect the others? That way people can define what they want in Makefile.local.
The last commit i made was moving in that direction because it doesn't make sense to run two separate branches for 4.1 and 4.2. see URT42
undead, on 07 August 2012 - 11:15 PM, said:
I noticed some parts had #ifdef but others didn't. For instance, the SACC part is enabled by default. Speaking of SACC. Is it really necessary to rename all of the cvars to have a sacc_ prefix?
The cvars were renamed because a few months ago, slackin requested that I keep them because he keeps track of sacc users via pugbot. (userinfo strings)
undead, on 07 August 2012 - 11:15 PM, said:
Someone asked about bumpy. Since the latest ioquake3 has a modular renderer, you could easily add a second renderer that supports bumpy along with the default. You can switch between them at runtime. However, I don't recommend it since bumpy isn't being maintained.
Hence the reason, no bumpy. However, USE_RENDERER_DLOPEN will allow anyone to easily swap it out, yes.
undead, on 07 August 2012 - 11:15 PM, said:
What I did for my 4.1 client was go through all of frozen sand's changes in their tarball. They had a mixture of SVN versions and things that weren't necessary so I made it as small of a diff as possible. I think a client that tracks the latest ioquake3 like yours may want to do a similar task. It sucks, but at least you know all of the changes are looked at.
My post before was deleted, but if anyone is interested, here's how you can see what changed in diRf compared to upstream ioquake3:
$ git clone git://github.com/urtdevs/diRf_client.git
$ cd diRf_client
$ git remote add upstream git://github.com/undeadzy/ioquake3_mirror.git
$ git fetch upstream
$ git diff upstream/master
I try to keep ioquake3_mirror up to date via 'git svn rebase'. I don't make any changes to that repo. It's all identical to upstream.
Because I'm a git noob, this all started with a diff between ioUrbanTerror_2007 - I don't remember what SVN of ioquake3 it was based on (at the time I did lol) - and ioquake3. Then manually hacked it into ioquake3 trunk, added sacc and dmaHD. Then I realized that there needs to be a way to keep track of all these changes. I'm doing my best. Could always use more help! :S