[Mazter]

More about this, I told ludwig that do did send the patches, here's his response:

Quote

Mazter wrote:
> On Jan 24, 2008 3:04 PM, Ludwig Nussel <ludwig.nussel@web.de> wrote:
>
> >
> > There was a posting last April. It pointed to a patch in
> > Sourceforge's tracker that adds Battleye und UT4 game types. I
> > refused Battleye (dead now anyways) but added the game types.
> >
> >
> > https://sourceforge....e=xqf-developer
> >
>
> Ahhh Ok nice !! but which XQF version includes the changes you merged ?

The current svn version. No release yet. I plan to release 1.0.6
when ut3 gets released.

Snapshot builds of xqf and qstat are available via the opensuse
build service though (http://software.opensuse.org).

So it seems that some of fate swarm changes indeed made into the official version, just the BattlEye patch was rejected. The patch you sent was the last one you made ? as I see in this forum post it seems that you updated like eight times your xqf version  with your changes that included more stuff other than just game types.

[mitsubishi]

I don't recall details, they shouldn't be the last ones. At the moment I'm not even on linux to be honest.

[Mazter]

It would be nice if you could check if there where the latest ones. If you want, you can send them to me and I'll deal with XQF mantainers to get them merged.

Oh, and thanks for your work btw

[mitsubishi]

As I don't use linux at the moment, I don't have the tools readily available. One can do a diff against 1.0.5 though. It's based on v.1.0.5.

[DarthCheney (old)]

Think I found a bug of sorts:

The instructions in the original post say to enable geoip, but if you don't, the build crashes.  The problem lies in
filter.c line 257 function server_filter_print().[pre]unsigned i[/pre] is only declared if USE_GEOIP is defined.  However, the added for loop at the end of the function uses i outside of the USE_GEOIP #ifdef.  Either the for loop needs to be brought inside of the #ifdef, or (more likely) the declaration needs to be moved outside.  Heres the original code (with printfs obfuscated)

line 257:void server_filter_print(struct server_filter_vars* f)
{
#ifdef USE_GEOIP
 unsigned i;
#endif

  <<< a bunch of printfs >>>

#ifdef USE_GEOIP

  for (i =0; i< f->countries->len;i++)
        printf("  country id %d: %d n", i + 1, g_array_index(f->countries,int,i));
  //printf("n");

#endif

  for (i = 0; f->svars && f->svars[i]; i++)
    printf("  custom svar %d: %s n", i + 1, f->svars[i]);

  printf("n");

}

One fix is

line 257:void server_filter_print(struct server_filter_vars* f)
{
#ifdef USE_GEOIP
 unsigned i;
#endif

  <<< a bunch of printfs >>>

#ifdef USE_GEOIP

  for (i =0; i< f->countries->len;i++)
        printf("  country id %d: %d n", i + 1, g_array_index(f->countries,int,i));
  //printf("n");

  for (i = 0; f->svars && f->svars[i]; i++)
    printf("  custom svar %d: %s n", i + 1, f->svars[i]);

  printf("n");
#endif

}

but probably want we want is

line 257:void server_filter_print(struct server_filter_vars* f)
{
 unsigned i;

  <<< a bunch of printfs >>>

#ifdef USE_GEOIP

  for (i =0; i< f->countries->len;i++)
        printf("  country id %d: %d n", i + 1, g_array_index(f->countries,int,i));
  //printf("n");
#endif

  for (i = 0; f->svars && f->svars[i]; i++)
    printf("  custom svar %d: %s n", i + 1, f->svars[i]);

  printf("n");

}

BTW, my c is a little rusty, is there some reason we dont just declare the incrementer (i) in the for loop? eg

#ifdef USE_GEOIP
  for (unsigned i =0; i< f->countries->len;i++)
        printf("  country id %d: %d n", i + 1, g_array_index(f->countries,int,i));
  //printf("n");
#endif

  for (unsigned i = 0; f->svars && f->svars[i]; i++)
    printf("  custom svar %d: %s n", i + 1, f->svars[i]);

  printf("n");

}

[mitsubishi]

Please do make patches. I'm done editing it myself (not even using it at the moment).

[Mazter]

Ok, I have made a patch with the changes made by fate swarm and sent them to Ludwig hoping hi includes them on 1.0.6. Also  I have updated PCLinuxOS rpm to include it and I'll hope do the same for Mandriva so users of this two distros will have the patch included anyway

[Nationalist]

Does anyone have an rpm for SuSE 10.3?

[Mazter]

Quote

Does anyone have an rpm for SuSE 10.3?

Have you checked SuSE repositories? I'm pretty sure it should be there...

[Nationalist]

Yes, I see it on the repos. But is this the version that filters urt game types?